-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQTT climate preset_modes rework #66062
MQTT climate preset_modes rework #66062
Conversation
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( |
56bead5
to
dd9be41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup, thanks @jbouwh 👍
Let's extend the deprecation period to 6 months though, so 2022.9
We should consider bumping removal of CONF_SEND_IF_OFF
to the same release so there's only one planned release where we break MQTT climate.
dfd678a
to
f9a619a
Compare
Updated the deprecation comments to 2022.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jbouwh 👍
Breaking change
hold
andaway
mode config settings will be deprecated and removed with release 2022.9. This will break existing integrations that make use of these config settings. Integrations should use the newpreset_mode
configuration options.Proposed change
This PR simplifies the use of
preset_modes
with the MQTT climate platform.This is a follow up on https://developers.home-assistant.io/blog/2019/07/03/climate-cleanup/.
It will introduce a
preset_mode_command_topic
,preset_mode_command_template
,preset_mode_state_topic
andpreset_mode_value_template
to replace the current hold and away mode settings.The following configuration settings will be deprecated:
away_mode_command_topic
away_mode_state_topic
away_mode_state_template
hold_mode_command_topic
hold_mode_command_template
hold_mode_state_topic
hold_mode_state_template
hold_mode_state_template
hold_modes
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: